add function to preprocess for phase data#63
Merged
kenjiro-mk merged 9 commits intomasterfrom Jan 7, 2026
Merged
Conversation
…class.py and soccer_load_data.py for bepro.
Collaborator
|
@KentoKuroda |
Init Test Results 📝
|
Init Test Results 📝
|
Init Test Results 📝
|
Collaborator
Author
|
@kenjiro-mk お待たせしました。おそらく解消できたと思います。 |
Collaborator
|
また，必要なライブラリなどは問題なかったでしょうか？もしあればpyproject.tomlに追加してください．そして，最後はprojectのversionを0.1.42のように1つアップデートをお願いします．このPRが終わればpypiでアップデートをする必要があります． |
Init Test Results 📝
|
Init Test Results 📝
|
Init Test Results 📝
|
Collaborator
Author
|
新たに必要なライブラリはなかったためpyproject.tomlの内容は特に変えていませんが、バージョンのみ0.1.42に変更しました。お願いします。 |
Collaborator
|
sb_event_path=f'D:/lab/My_Research/Github/OpenSTARLab/PreProcessing/test/sports/event_data/statsbomb/{sb_match_id}_events.pkl' 上記のような箇所を以下を参考に修正をお願いします． |
Init Test Results 📝
|
Init Test Results 📝
|
Init Test Results 📝
|
Collaborator
Author
|
ローカルのパスを除きました。また、テスト用のコードをコメントアウトしました。 |
kenjiro-mk
approved these changes
Jan 7, 2026
| elif data_provider == 'statsbomb_skillcorner': | ||
| sb_match_id = 3894537 # 843, 537 | ||
| sc_match_id = 1018887 # 1498966, 1018887 | ||
| sb_event_path=f'D:/lab/My_Research/Github/OpenSTARLab/PreProcessing/test/sports/event_data/statsbomb/{sb_match_id}_events.pkl' |
Collaborator
There was a problem hiding this comment.
．SARはテストデータを置いているのですが，それがなければハードコードされたパスをdatafactory_directory_pathのようなパスに変更してください．よろしくお願いいたします．
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase dataを作成するためのコードを一通り作成したので、ご確認よろしくお願いいたします。